openedx / openedx-k8s-harmony

A Prototype Helm Chart for deploying multiple Open edX instances (via Tutor) onto a cluster.
GNU Affero General Public License v3.0
10 stars 14 forks source link

refactor: extend ingress hosts #74

Closed gabor-boros closed 6 months ago

gabor-boros commented 6 months ago

Description

This PR adds the Discovery and Ecommerce hosts to the ingress configuration if the corresponding variables are defined.

Testing

openedx-webhooks commented 6 months ago

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 6 months ago

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 6 months ago

Thanks for the pull request, @gabor-boros! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

MoisesGSalas commented 6 months ago

@gabor-boros, what are your thoughts about splitting the ingress objects per service?

One issue with having all the services in a single object is that if you were to make use of the server-snippet annotation it would apply to all the hosts.

gabor-boros commented 6 months ago

@MoisesGSalas Sure! I'm going to refactor it today. This is a great idea.

openedx-webhooks commented 6 months ago

@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.