openedx / openedx-k8s-harmony

A Prototype Helm Chart for deploying multiple Open edX instances (via Tutor) onto a cluster.
GNU Affero General Public License v3.0
10 stars 14 forks source link

chore(bump): upgrade helm chart global dependencies #86

Closed Ian2012 closed 2 weeks ago

Ian2012 commented 1 month ago

Description

This PR upgrades the helm chart dependencies to the latest version.

Cert manager cannot be upgraded to v1.16 because of this bug: https://github.com/cert-manager/cert-manager/issues/1829

The upgrade was already tested on a production k8s cluster by upgrading from the current version to the new one.

openedx-webhooks commented 1 month ago

Thanks for the pull request, @Ian2012!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-k8s-harmony-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

Ian2012 commented 1 month ago

@bradenmacdonald I've not reviewed other helms charts because I don't have any use for them and I'm unsure how to test it. Good to know for a follow-up if anyone of you folks want to take a look.

Ian2012 commented 3 weeks ago

can we get this merged and released before sumac?

bradenmacdonald commented 3 weeks ago

If we can get one more +1 from either @gabor-boros or @jfavellar90 then I think this is good to merge.

jfavellar90 commented 3 weeks ago

@gabor-boros Hi, we would like to get you involved in this conversation since we are not updating the following dependencies since we are not very familiar with testing them:

Are you OK with this approach of merging this PR as it is and leaving the update of the missing dependencies for a follow-up task? Or do you prefer checking such dependencies in this PR to apply the update of all the dependencies?

gabor-boros commented 3 weeks ago

Hey @jfavellar90 I'm going to review this later today!

gabor-boros commented 3 weeks ago

@jfavellar90 I won't be able to test Velero and OpenFaas today. However, I don't think I should block this PR to be merged.

So, let's merge this PR and I can update OpenFAAS and Velero separately later.