Closed bradenmacdonald closed 10 months ago
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@pomegranited I think this is ready for review, though I may need to make some changes once I try to integrate it into edx-platform. Haven't done that side of it yet.
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
https://github.com/openedx/modular-learning/issues/133
This PR updates the "get object tags" API so that it returns the results grouped by taxonomy, and sorted into "tree order" (just like the "get tags" API does).
I've also added a new API that can retrieve the # of tags applied to each unit for every unit on the course, in a single database query.
TODO
Before merging, check how this integrates into edx-platform.
Follow up
I could do a separate PR to allow including "available but unused" taxonomies in the result - those which don't yet have any tags applied to the object, but which the user could use to add additional tags. The permissions of that are somewhat complicated though so it's best as its own PR. Or perhaps it's fine to make the frontend construct this just by querying the list of available taxonomies directly, and appending them to its own list.
Private ref: FAL-3547