feat: add import taxonomy endpoint

openedx / openedx-learning

GNU Affero General Public License v3.0

5 stars 8 forks source link

feat: add import taxonomy endpoint #112

Closed rpenido closed 10 months ago

rpenido commented 10 months ago

Description

Add a rest api endpoint to import taxonomies

Supporting Information

Part of https://github.com/openedx/modular-learning/issues/115

Testing instructions

Please ensure that the tests cover the expected behavior of the view

Private-ref: FAL-3532

openedx-webhooks commented 10 months ago

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

rpenido commented 10 months ago

I think this is ready for a ~final~ review @pomegranited !

But I prefer to wait for the development of the edx-platform part before merging.

rpenido commented 10 months ago

~ToDo: Bump version before merge~

bradenmacdonald commented 10 months ago

@pomegranited From a very quick look, this seems good to me. You're a CC for this repo so I'm happy for you to approve and merge it, unless you want me to do a second review?

pomegranited commented 10 months ago

@bradenmacdonald Could you do a 2nd review? I'm happy to merge this when it's ready.

bradenmacdonald commented 10 months ago

@pomegranited It looks good to me! Just saw some minor things to clean up.

pomegranited commented 10 months ago

Thanks for fixing those docstrings @rpenido ! Could you push a version bump when you're done addressing @bradenmacdonald 's review, and I'll get this merged.

rpenido commented 10 months ago

Thanks for fixing those docstrings @rpenido ! Could you push a version bump when you're done addressing @bradenmacdonald 's review, and I'll get this merged.

Done c4fe95d!

openedx-webhooks commented 10 months ago

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

pomegranited commented 10 months ago

Version 0.3.3 released.