Closed rpenido closed 10 months ago
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
I think this is ready for a ~final~ review @pomegranited !
But I prefer to wait for the development of the edx-platform part before merging.
~ToDo: Bump version before merge~
@pomegranited From a very quick look, this seems good to me. You're a CC for this repo so I'm happy for you to approve and merge it, unless you want me to do a second review?
@bradenmacdonald Could you do a 2nd review? I'm happy to merge this when it's ready.
@pomegranited It looks good to me! Just saw some minor things to clean up.
Thanks for fixing those docstrings @rpenido ! Could you push a version bump when you're done addressing @bradenmacdonald 's review, and I'll get this merged.
Thanks for fixing those docstrings @rpenido ! Could you push a version bump when you're done addressing @bradenmacdonald 's review, and I'll get this merged.
Done c4fe95d!
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
Add a rest api endpoint to import taxonomies
Supporting Information
Testing instructions
Private-ref: FAL-3532