Python API to get tag counts, ignore deleted/disabled ObjectTags by default [FC-0036]

openedx / openedx-learning

GNU Affero General Public License v3.0

5 stars 8 forks source link

Python API to get tag counts, ignore deleted/disabled ObjectTags by default [FC-0036] #115

Closed bradenmacdonald closed 11 months ago

bradenmacdonald commented 11 months ago

This PR:

Makes the get_object_tag_counts API available via python as well as REST. Previously it was REST-only.
Makes the get_object_tags and get_object_tag_counts APIs ignore tags from deleted or disabled taxonomies by default. Anything else would be confusing for users. Keep in mind, we do preserve the underlying ObjectTag data; we just don't want to display it.

This is for https://github.com/openedx/modular-learning/issues/118 part 1b.

Private ref: FAL-3564.

openedx-webhooks commented 11 months ago

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 11 months ago

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

bradenmacdonald commented 11 months ago

FYI @ChrisChV since you mentioned the issue with deleted/disabled object tags being included in the APIs - I fixed it here.

openedx-webhooks commented 11 months ago

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.