Closed ChrisChV closed 7 months ago
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@rpenido It's ready for another review
LGTM @ChrisChV! :+1:
@ormsbee If you have time, could you please review/merge this PR while @bradenmacdonald is off?
Thank you!
@rpenido: I'm also technically off until Jan 2. Is this blocking your work?
@rpenido: I'm also technically off until Jan 2. Is this blocking your work?
No @ormsbee. This is not urgent and could wait. Sorry to bother you!
Thank you for your response and have a good holiday! :smiley:
@bradenmacdonald It's ready for another review
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This fix an error when it comes to performing actions on a taxonomy with tags that have
external_id=None
More info
Part of: https://github.com/openedx/modular-learning/issues/126
Testing instructions
Please ensure that the tests cover the expected behavior
After merge