openedx / openedx-learning

GNU Affero General Public License v3.0
5 stars 8 forks source link

Add total descendant count to tag list APIs [FC-0036] #156

Closed bradenmacdonald closed 5 months ago

bradenmacdonald commented 5 months ago

This PR updates the APIs for retrieving the tags in the taxonomy, so that they state not only how many direct children they have, but also how many total descendants.

The direct children count is still included, not only to preserve backwards compatibility, but because it's necessary to compute pagination and display a "load more children" button when necessary.

What about performance of these queries? I ran the whole test suite before and after this change, which includes some very large taxonomies, and there was no measurable difference on average.

Ref: https://github.com/openedx/modular-learning/issues/191

Private ref: FAL-3655

Note: needs a version bump when merged.

openedx-webhooks commented 5 months ago

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 5 months ago

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.