openedx / openedx-learning

GNU Affero General Public License v3.0
5 stars 8 forks source link

refactor: tag_object param order #165

Closed rpenido closed 5 months ago

rpenido commented 5 months ago

Description

This PR changes the param order in the tag_content function and the tests accordingly. PS: all function calls at edx-platform use named parameters, so this PR doesn't impact there.

Testing Instructions


Private ref: FAL-3621

openedx-webhooks commented 5 months ago

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

rpenido commented 5 months ago

Hi @bradenmacdonald ! This is a small fix that I made when I was developing https://github.com/openedx/modular-learning/issues/180. Can you review it?

bradenmacdonald commented 5 months ago

Does this break anything in edx-platform though? Will we have to make corresponding changes on that side before bumping the version?

rpenido commented 5 months ago

Does this break anything in edx-platform though? Will we have to make corresponding changes on that side before bumping the version?

No. All calls from edx-platform use named parameters.

openedx-webhooks commented 5 months ago

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.