openedx / openedx-learning

GNU Affero General Public License v3.0
5 stars 8 forks source link

[FC- 0049] feat: Features to enable import/export courses #172

Closed ChrisChV closed 3 months ago

ChrisChV commented 4 months ago

Description

Support information

Testing instructions

openedx-webhooks commented 4 months ago

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

ChrisChV commented 3 months ago

Thanks @rpenido. I found an issue exporting tags that contains ,. I fixed that issue here https://github.com/openedx/openedx-learning/pull/172/commits/c85cfc8fa9ea4c7747fb38387477dcdc011be535

Update avoid create tags that contains the tags csv separator: In some taxonomies (Lightcast Open Skills Taxonomy) there are tags that contains ,. This character is used as separator on export tags, so causes issues. This separator will change to ;, so we need to avoid to create tags with ;.

Could you review that commit? @bradenmacdonald After that, it would be ready for your review.

rpenido commented 3 months ago

Thanks @rpenido. I found an issue exporting tags that contains ,. I fixed that issue here c85cfc8

Update avoid create tags that contains the tags csv separator: In some taxonomies (Lightcast Open Skills Taxonomy) there are tags that contains ,. This character is used as separator on export tags, so causes issues. This separator will change to ;, so we need to avoid to create tags with ;.

Could you review that commit? @bradenmacdonald After that, it would be ready for your review.

Done @ChrisChV! I tested it again and is working fine.

openedx-webhooks commented 3 months ago

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.