[FC-0036] feat: Update ObjectTagView

openedx / openedx-learning

GNU Affero General Public License v3.0

5 stars 8 forks source link

[FC-0036] feat: Update ObjectTagView #180

Closed ChrisChV closed 3 months ago

ChrisChV commented 3 months ago

Description

Updates ObjectTagView Put request to update multiple taxonomies in one request

Supporting information

Github issue: https://github.com/openedx/modular-learning/issues/190
Related PRs:
- https://github.com/openedx/frontend-app-course-authoring/pull/939
- https://github.com/openedx/edx-platform/pull/34490
Internal ticket: FAL-3645

Testing instructions

Follow the testing instructions of https://github.com/openedx/frontend-app-course-authoring/pull/939

openedx-webhooks commented 3 months ago

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

bradenmacdonald commented 3 months ago

@ChrisChV Is this ready for review?

ChrisChV commented 3 months ago

@bradenmacdonald Yes, It's ready :+1:

bradenmacdonald commented 3 months ago

@ChrisChV It LGTM. I'll let @yusuf-musleh test it first before I merge it though.

Once we merge this and update edx-platform, won't it break tagging until we've updated course-authoring too though? It may have been better to implement this in a backwards compatible way. But I guess it's fine, as long as we coordinate the merges all at the same time.

ChrisChV commented 3 months ago

Once we merge this and update edx-platform, won't it break tagging until we've updated course-authoring too though?

Yes, It is necessary to merge https://github.com/openedx/frontend-app-course-authoring/pull/939 and https://github.com/openedx/edx-platform/pull/34490 at the same time

openedx-webhooks commented 3 months ago

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

ChrisChV commented 3 months ago

@bradenmacdonald could you create a new tag with the version 0.9.1?

bradenmacdonald commented 3 months ago

@ChrisChV Done!