search

openedx / openedx-learning

GNU Affero General Public License v3.0
5 stars 11 forks source link

Remove Django 3.2 collations compatibility hack #212

Closed ormsbee closed 3 months ago

ormsbee commented 3 months ago

Setting the collation via Field db_parameters was not properly supported before Django 4.x. We worked around this with a Django 3.2-compatible hack in https://github.com/ormsbee/openedx-learning/commit/084ec21a0292584f42f79930b6d6fe3bcf0ef08b. Now that we require at least Django 4.2, we no longer need the compatibility hack.

ormsbee commented 3 months ago

It's stupid, but I'm irrationally fond of the hack that I'm removing here. I mean, the hack is absolutely terrible and we're definitely better off getting rid of it, but it worked surprisingly well. 😛

kdmccormick commented 3 months ago

Yeah, OOP and getter/setter magic can drive me crazy but this is a good demonstration of when it's really helpful 😄