openedx / openedx-learning

GNU Affero General Public License v3.0
5 stars 11 forks source link

feat: Copy object tags [FC-0062] #236

Closed ChrisChV closed 1 month ago

ChrisChV commented 1 month ago

This PR adds:

Supporting information

Testing instructions

Deadline

ASAP

openedx-webhooks commented 1 month ago

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @axim-engineering. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

bradenmacdonald commented 1 month ago

@ChrisChV I can merge this when you fix the conflicts and reply - let me know.

ChrisChV commented 1 month ago

@bradenmacdonald It's ready for merge.

Suggested some changes. Thinking ahead, we may also need an API to "convert" the tags if/when the link is broken. That is, if the user links some library into a course, then later breaks the link, the tags that were read-only would need to be changed to is_copied=False so that they can be edited. But we can do that in a separate PR if you prefer.

Sorry I forgot this, yes, we can do this in a separate PR