Taxonomy view/management REST APIs

openedx / openedx-learning

GNU Affero General Public License v3.0

5 stars 8 forks source link

Taxonomy view/management REST APIs #63

Closed rpenido closed 1 year ago

rpenido commented 1 year ago

Description

This PR adds support for creating, viewing, updating and deleting Taxonomies via REST APIs, with the permissions applied accordingly.

Supporting Information

Closes https://github.com/openedx/modular-learning/issues/73

Testing instructions

Ensure that all endpoints in the related issue are implemented.
Ensure that the tests cover the expected behaviour of the view and permissions as described in the related issue.

To do before merge

[ ] squash and merge this change (don't just merge)

openedx-webhooks commented 1 year ago

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

pomegranited commented 1 year ago

@rpenido Ok to leave this PR here in Draft, but until https://github.com/openedx/openedx-learning/pull/58 is merged, do you mind to submit your work to a open-craft PR against that branch instead? Then we can see the diff between what you're adding and what that PR adds.

rpenido commented 1 year ago

@pomegranited Updated this PR. I think we are ready to review here!

pomegranited commented 1 year ago

Thanks for applying those changes @rpenido ! This is ready for @ormsbee and/or @bradenmacdonald 's review now.

rpenido commented 1 year ago

@pomegranited I made the changes with new commits: 2ccae75d75227729a3beca0b010d0995e4430697 and cec362d2cfc5342949e743cd6097c1ca750d8dd5. That way, I think it is easier to review.

Let me know if I should squash the commits, or you can do it yourself.

Thank you!