search

openedx / openedx-webhooks

Webhooks for the Open edX GitHub and JIRA
http://openedx-webhooks.herokuapp.com/
Apache License 2.0
12 stars 20 forks source link

feat: Update the community PR message #288

Closed xitij2000 closed 4 months ago

xitij2000 commented 6 months ago

This change updates the community PR message to provide better guidance and updated links to the latest documentation.

The message now also directs contributors to the correct team or person to tag to get their PR reviewed and merged.

openedx-webhooks commented 6 months ago

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 6 months ago

Addresses https://github.com/openedx/openedx-webhooks/issues/287 by implementing new welcome message for OSPRs.

itsjeyd commented 6 months ago

FYI @mphilbrick211 @arbrandes

itsjeyd commented 5 months ago

Hey @xitij2000, could you have a look and see what's keeping the tests from passing here? Once the build is green we'll be able to move forward with engineering review. (Commenting as OSPR manager right now :))

xitij2000 commented 5 months ago

Hey @xitij2000, could you have a look and see what's keeping the tests from passing here? Once the build is green we'll be able to move forward with engineering review. (Commenting as OSPR manager right now :))

It's a known issue with rate limits when uploading coverage. The tests themselves have passed. I don't know if an admin running the tests will bypass this.

itsjeyd commented 5 months ago

@xitij2000 OK I see, we should be good to put this up for review then.

@feanil This is the PR that updates the OSPR welcome message that we discussed in the maintenance working group a while back. Would you be able to review it? Happy to ping someone else if you don't have bandwidth, please let us know.

CC @mphilbrick211

feanil commented 5 months ago

Hey, all. Sorry for the quite, I am planning on reviewing this, this week.

itsjeyd commented 5 months ago

Great, thanks @feanil.

feanil commented 4 months ago

Also, the coverage test failure should be resolved now if you rebase the PR.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.90%. Comparing base (a3d63a8) to head (6121962). Report is 31 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #288 +/- ## ========================================== + Coverage 89.76% 89.90% +0.13% ========================================== Files 38 38 Lines 2882 2921 +39 Branches 397 407 +10 ========================================== + Hits 2587 2626 +39 Misses 268 268 Partials 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

feanil commented 4 months ago

Ok, changes have been tested here: https://github.com/openedx/mdrst/pull/40 and https://github.com/openedx/mdrst/pull/41

I'm merging and pushing this to production.

openedx-webhooks commented 4 months ago

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

feanil commented 4 months ago

Change is deployed to production, thanks for all the hard work everyone, appreciate your patience as always!

itsjeyd commented 3 months ago

Happy to see this land, thanks @feanil!