openedx / paragon

💎 An accessible, theme-ready design system built for learning applications and Open edX.
https://paragon-openedx.netlify.app
Apache License 2.0
119 stars 65 forks source link

RTL: ProductTour checkpoint arrow style error #1634

Open ARMBouhali opened 2 years ago

ARMBouhali commented 2 years ago

As the title suggests, the ProductTour RTL support is incomplete.

Descrption

As I was testing frontend-app-learning both in local dev (master) and in our [demo site] (fennx.fennectech.net) (nutmeg.1) I've noticed that user tours in Arabic have 2 style issues with the checkpoint dialog arrow: (with screenshots)

Issue 1

when popper tooltip placement is top or bottom. the arrow appears shifted to the right by half the size of the dialog.

Issue 2

when popper tooltip placement is left or right, the arrow direction is reversed.

I currently lack a working paragon dev environment to provide a fix myself. I also lack information about why the ProductTour arrow was styled this way in the first place.

Possible reason for issue 1

I'd be glad if the person who wrote this part of the style could assist us in providing a fix for the two issues above. Thanks in advance

ARMBouhali commented 1 year ago

@ghassanmas that PR looks strange. I think I was misunderstood. The issues are with the tooltip arrow that points to the user tour's checkpoint anchor (outline, user tour link, tabs, etc.)

ARMBouhali commented 1 year ago

As I have noticed. The docs website for paragon does not show The learning MFE uses v19.18.3 of paragon. Maybe it has been solved?

ARMBouhali commented 1 year ago

the same is happening with this frontend-app-authn password tooltip Paragon version: 19.10.2