Open ARMBouhali opened 2 years ago
@ghassanmas that PR looks strange. I think I was misunderstood. The issues are with the tooltip arrow that points to the user tour's checkpoint anchor (outline, user tour link, tabs, etc.)
As I have noticed. The docs website for paragon does not show The learning MFE uses v19.18.3 of paragon. Maybe it has been solved?
the same is happening with this frontend-app-authn password tooltip Paragon version: 19.10.2
As the title suggests, the ProductTour RTL support is incomplete.
Descrption
As I was testing frontend-app-learning both in local dev (master) and in our [demo site] (fennx.fennectech.net) (nutmeg.1) I've noticed that user tours in Arabic have 2 style issues with the checkpoint dialog arrow: (with screenshots)
Issue 1
when popper tooltip placement is
top
orbottom
. the arrow appears shifted to the right by half the size of the dialog.Placement: top (expected blue arrow in the center top of the dialog, appearing far to the left)
Placement: top (expected gray arrow in the center bottom of the dialog, appearing far to the left)
Issue 2
when popper tooltip placement is
left
orright
, the arrow direction is reversed.I currently lack a working paragon dev environment to provide a fix myself. I also lack information about why the ProductTour arrow was styled this way in the first place.
Possible reason for issue 1
popper
library does a good job listening to changes on the#pgn__checkpoint
element and positions the arrow accordingly.src/ProductTour/Checkpoint.scss
define the shape of the arrow and adjust its position slightly, but they enter in conflict withelement.style
applied bypopper
to the#pgn__checkpoint-arrow
element. The overrides work well for LTR, but things need to be rewritten for RTL support.Checkpoint.scss
applied to#pgn__checkpoint-arrow
and I could have the arrow nearly centered.I'd be glad if the person who wrote this part of the style could assist us in providing a fix for the two issues above. Thanks in advance