openedx / paragon

💎 An accessible, theme-ready design system built for learning applications and Open edX.
https://paragon-openedx.netlify.app
Apache License 2.0
121 stars 67 forks source link

Pagination component includes `.btn-primary` on all its buttons, when only the active page actually has `.btn-primary` styling #1787

Open adamstankiewicz opened 2 years ago

adamstankiewicz commented 2 years ago

All buttons in Pagination component have a .btn-primary class, despite having different style treatments depending on which page is active.

For example, in this screenshot, we're looking at the class names for the 2nd page button, which has a white background, not the typical primary button styles despite it having the .btn-primary class name:

image

This appears to be the result of the .page-link class.

This causes issues for consumes who may override the .btn-primary class and expect the Pagination component to still have the same look-and-feel as before, where only the active page gets the primary button styles, e.g.:

image

We're relying on the page-link class to override the .btn-primary class. Instead, we should use the proper button variants as necessary.

AC

adamstankiewicz commented 2 years ago

[inform] @kiram15 intends to triage within the enterprise quokkas team.

viktorrusakov commented 1 year ago

https://github.com/openedx/paragon/pull/1911