search

openedx / paragon

💎 An accessible, theme-ready design system built for learning applications and Open edX.
https://paragon-openedx.netlify.app
Apache License 2.0
119 stars 65 forks source link

Card loading state #2528

Open adamstankiewicz opened 1 year ago

adamstankiewicz commented 1 year ago

It appears the Card skeleton loading state when the isLoading prop is passed is no longer working, at least on the documentation website:

image

https://paragon-openedx.netlify.app/components/card/#with-loading-state

Playground demo

### Tasks
- [ ] Verify `isLoading` on `Card` is working in consuming MFEs.
- [ ] Understand and fix `isLoading` on Paragon docs site.
adamstankiewicz commented 1 year ago

Also I think that it is good idea to implement isLoading for Card.Body too.

@PKulkoRaccoonGang What would the Card look like with isLoading when it used the Card.Body, containing a Card.Header and Card.Section? Given this bug currently, I'm unable to reproduce the expected current state. Is the Card.Header's and Card.Section's isLoading support not sufficient?

PKulkoRaccoonGang commented 1 year ago

@adamstankiewicz thanks! I will check after resolved problem with the Skeleton