openedx / platform-plugin-aspects

Aspects plugins for the Open edX LMS and Studio
Apache License 2.0
2 stars 8 forks source link

fix: serialize datetime objects as strings #52

Closed Ian2012 closed 4 months ago

Ian2012 commented 4 months ago

Description

This PR fixes an issue when serializing as JSON the course data where some attributes were dates cannot be encoded by default. We use the code from event-tracking to allow the serialization of datetime objects as JSON.

openedx-webhooks commented 4 months ago

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

github-actions[bot] commented 4 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  platform_plugin_aspects
  __init__.py
  platform_plugin_aspects/extensions
  filters.py
  platform_plugin_aspects/management/commands
  load_test_tracking_events.py
  monitor_load_test_tracking.py
  platform_plugin_aspects/sinks
  serializers.py 30, 32-35
Project Total  

This report was generated by python-coverage-comment-action

bmtcril commented 4 months ago

I'd rather not bring in event-tracking and all of its sub-dependencies just for this one small class that has basically not changed in 11 yrs. I'd rather just copy it in, or use an altered version of the accepted SO answer with the addition of the very good UTC changes from event-tracking.

openedx-webhooks commented 4 months ago

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.