[Product Pull Request] Allow delete course content in Studio only for admin users

jmakowski1123 commented 1 year ago

For Contributing Author:

This is the Primary Product Ticket for the following community contribution: Allow delete course content in Studio only for admin users

Checklist prior to undergoing Product Review:

The following information is required in order for Product Managers to be able to review your pull request:

[x] Explanation of the problem being solved
[x] Description of how users will be impacted, and which users will be impacted
[x] Screenshots or video showing the functionality or fix, before and after
[x] Reproduction steps and/or testing steps

Only if necessary:

[ ] If necessary, links to corresponding configuration changes
[x] If necessary, links to corresponding enablement changes, particularly waffle/toggle status details

For Product Manager doing the review:

What criteria should be analyzed from Product to approve a PR?

The problem being solved by the feature or fix is clear.
There is clarity on how the change or fix will impact the end user.
It is clear that the change will not negatively impact users or other areas of the platform.
The change is implemented comprehensively.
Any changes to UI use the current, standard Paragon Design System: https://paragon-openedx.netlify.app/

github-actions[bot] commented 1 year ago

Thanks for your submission, @openedx/open-edx-project-managers will review shortly.

jmakowski1123 commented 1 year ago

Earlier product and community input:

Marco: https://github.com/openedx/edx-platform/pull/27857#issuecomment-955003315 Dean: https://github.com/openedx/edx-platform/pull/27857#issuecomment-1097616792 Santiago: https://github.com/openedx/edx-platform/pull/27857#issuecomment-1421515367

jmakowski1123 commented 1 year ago

Product Information:

Problem and users impacted:

Description

This PR and a check to show/hide the delete button on the course content in Studio. With these changes, the delete button is only visible to the admin user one with the CourseInstructor role only and will not be visible to the CourseStaff role users.

Course Outline view for the user when it has admin access to the course admin_role_user_page_view

Course Outline view for the user when it has staff access to the course staff_role_user_page_view

Supporting information

JIRA Ticket: BB-5815

Testing instructions

Login with staff@example.com on https://studio.pr27857.sandbox.opencraft.hosting/. On this sandbox we have given the superuser privileges to staff@example.com
Go to the setting > Course team of the Demonstration Course
Add verified@example.com as the staff for the course
Login from the verified@example.com on the studio page
verified@example.com should not be able to see the delete button on the course outline page.

Enablement/Toggle info: Behind a waffle flag automatically toggled to off.

mphilbrick211 commented 1 year ago

Hi @cablaa77! Just following up on this to see if there's any updates?

mphilbrick211 commented 1 year ago

Hi @cablaa77! Just following up on this to see if there's any updates?

Link to Brad's update.

cablaa77 commented 1 year ago

It now requires engineering review. So that is next step I believe.

Best regards, Brad

On Mon, Apr 10, 2023 at 9:35 PM Michelle Philbrick @.***> wrote:

Hi @cablaa77 https://github.com/cablaa77! Just following up on this to see if there's any updates?

Link to Brad's update https://github.com/openedx/edx-platform/pull/27857#issuecomment-1502196802 .

— Reply to this email directly, view it on GitHub https://github.com/openedx/platform-roadmap/issues/225#issuecomment-1502560677, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2A6OGZ57YJLQQP3SNP4CHTXASYMTANCNFSM6AAAAAAU2QR5NM . You are receiving this because you were mentioned.Message ID: @.***>

sarina commented 5 months ago

Closing as this is marked "Abandoned" on the PR board. It may always be re-opened if needed.

openedx / platform-roadmap