openedx / public-engineering

General public issue repository for the Open edX engineering community
4 stars 2 forks source link

[DEPR]: Remove JWT_AUTH_REFRESH_COOKIE #190

Closed robrap closed 11 months ago

robrap commented 1 year ago

Proposal Date

2023-04-12

Target Ticket Acceptance Date

2023-06-15

Earliest Open edX Named Release Without This Functionality

Quince - 2023-10

Rationale

The setting JWT_AUTH_REFRESH_COOKIE is meaningless and unused, and should be cleaned up to avoid confusion.

In the very early days of introducing MFEs, we thought we were going to need this cookie in addition to the JWT cookie. However, it turned out we didn't need it, but the setting stuck around the contagion of it (being in cookiecutter and other template libraries) has resulted in it uselessly being copied to many repos.

Removal

The setting JWT_AUTH_REFRESH_COOKIE can simply be removed with no ramifications.

Replacement

No replacement needed.

Deprecation

No response

Migration

No response

Additional Info

Yagnesh1998 commented 1 year ago

@dianakhuang https://github.com/openedx/edx-platform/pull/32664 This pull request all tests passed successfully

robrap commented 1 year ago

[inform] I moved the edx org work to a separate ticket that would not block this DEPR: https://github.com/edx/edx-arch-experiments/issues/353.

robrap commented 1 year ago

@Yagnesh1998: If you could start by removing this from openedx/configuration. See https://github.com/search?q=repo%3Aopenedx%2Fconfiguration+JWT_AUTH_REFRESH_COOKIE&type=code. Once this is done, you can fix other repos. Thank you.

Yagnesh1998 commented 1 year ago

assign me

lokidil commented 11 months ago

anyone is working on this ? is this closed ?

Yagnesh1998 commented 11 months ago

@lokidil I'm working on it. Thanks.

robrap commented 11 months ago

Although there are still edx repos to complete, the openedx repos are complete and I am marking this as closed. Thank you @Yagnesh1998.