openedx / public-engineering

General public issue repository for the Open edX engineering community
3 stars 1 forks source link

Add `tox<4.0.0` as a constraint in every repo that uses tox and tox-battery #217

Closed feanil closed 8 months ago

feanil commented 8 months ago

Context

The tox-battery python package provides only one feature to the tox tool. It detects changes to the requirements files that are the deps of a tox environment and optionally re-builds the environments if there are changes to the requirements. The tox-battery package can't run with tox 4.0.0 because of incompatibilites. So make upgrade won't upgrade us to the latest version of tox in a bunch of repos. However tox>=4.0.0 has the requirements monitoring feature built-in and if we drop the tox-battery dependency, we'll get the latest tox with the right featureset.

Tasks

Relevant repos

Acceptance Criteria

thezaeemaanwar commented 8 months ago

In ecommerce repo, tox==3.14.6 is already there so not adding into that one

thezaeemaanwar commented 8 months ago

As per discussion with @openedx/arbi-bom, they're already working on it. See https://github.com/openedx/edx-lint/issues/336