[GH Request] Replace `tests (18)` branch protection requirements for Node 20

openedx / public-engineering

General public issue repository for the Open edX engineering community

4 stars 2 forks source link

[GH Request] Replace `tests (18)` branch protection requirements for Node 20 #281

Open jsnwesson opened 2 months ago

jsnwesson commented 2 months ago

Repository

axim-engineering

Urgency

Medium (< 2 weeks)

Requested Change

In order to complete the Node 20 upgrade for Learner Dashboard (issue ticket), the last ticket that removes Node 18 from the CI matrix is being blocked due to a test that runs on Node 18. It is a required check in the CI, so this PR can't be merged until that check is removed.

Reasoning

This will allow for the Node 20 Upgrade to be complete for Learner Dashboard.

github-actions[bot] commented 2 months ago

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

brian-smith-tcril commented 2 months ago

This will need to happen for us to merge all of the "phase 3" PRs for Node 20. Since all of those are waiting for Sumac https://github.com/openedx/public-engineering/issues/280 I've updated this ticket to be a catch-all instead of having people make one per repo.