openedx / repo-tools

Tools for repo maintenance, etc.
Apache License 2.0
30 stars 39 forks source link

fix: use default branch when openedx.org/release annotation is empty #511

Closed cmltaWt0 closed 3 months ago

cmltaWt0 commented 3 months ago

The bug is hard to detect.

The tool shows the correct count of repos to be cut but the result list lacks repos with null values in openedx.org/release annotation.

Find commits  : 100%|█████████████████████████| 45/45 [00:33<00:00,  1.36it/s]

Without the fix (41):

openedx/aspects-dbt
openedx/course-discovery
openedx/credentials
openedx/cs_comments_service
openedx/docs.openedx.org
openedx/ecommerce-worker
openedx/ecommerce
openedx/edx-documentation
openedx/edx-notes-api
openedx/edx-platform
openedx/enterprise-access
openedx/enterprise-catalog
openedx/enterprise-subsidy
openedx/event-bus-redis
openedx/frontend-app-account
openedx/frontend-app-authn
openedx/frontend-app-communications
openedx/frontend-app-course-authoring
openedx/frontend-app-discussions
openedx/frontend-app-ecommerce
openedx/frontend-app-gradebook
openedx/frontend-app-learner-dashboard
openedx/frontend-app-learner-record
openedx/frontend-app-learning
openedx/frontend-app-ora-grading
openedx/frontend-app-ora
openedx/frontend-app-payment
openedx/frontend-app-profile
openedx/frontend-app-publisher
openedx/frontend-app-support-tools
openedx/frontend-plugin-framework
openedx/license-manager
openedx/openedx-app-android
openedx/openedx-app-ios
openedx/openedx-demo-course
openedx/openedx-test-course
openedx/platform-plugin-aspects
openedx/testeng-ci
openedx/tutor-contrib-aspects
openedx/xblock-skill-tagging
openedx/xqueue

With fix (45):

openedx/aspects-dbt
openedx/axim-engineering
openedx/course-discovery
openedx/credentials
openedx/cs_comments_service
openedx/docs.openedx.org
openedx/ecommerce-worker
openedx/ecommerce
openedx/edx-documentation
openedx/edx-lint
openedx/edx-notes-api
openedx/edx-platform
openedx/enterprise-access
openedx/enterprise-catalog
openedx/enterprise-subsidy
openedx/event-bus-redis
openedx/frontend-app-account
openedx/frontend-app-authn
openedx/frontend-app-communications
openedx/frontend-app-course-authoring
openedx/frontend-app-discussions
openedx/frontend-app-ecommerce
openedx/frontend-app-gradebook
openedx/frontend-app-learner-dashboard
openedx/frontend-app-learner-record
openedx/frontend-app-learning
openedx/frontend-app-ora-grading
openedx/frontend-app-ora
openedx/frontend-app-payment
openedx/frontend-app-profile
openedx/frontend-app-publisher
openedx/frontend-app-support-tools
openedx/frontend-plugin-framework
openedx/frontend-template-application
openedx/license-manager
openedx/openedx-app-android
openedx/openedx-app-ios
openedx/openedx-demo-course
openedx/openedx-test-course
openedx/platform-plugin-aspects
openedx/repo-tools
openedx/testeng-ci
openedx/tutor-contrib-aspects
openedx/xblock-skill-tagging
openedx/xqueue
openedx-webhooks commented 3 months ago

Thanks for the pull request, @cmltaWt0! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

cmltaWt0 commented 3 months ago

@kdmccormick @feanil This is a proposed change to use default branch when we have a null values in openedx.org/release annotation.

cmltaWt0 commented 3 months ago

Closing the PR as we decided that the current behaviour is desired.

openedx-webhooks commented 3 months ago

@cmltaWt0 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.