openedx / tutor-contrib-aspects

The Open Analytics Reference System - Tutor plugin
Apache License 2.0
10 stars 14 forks source link

fix: override pre-generated database connection #863

Closed Ian2012 closed 4 months ago

Ian2012 commented 4 months ago

Description

It was supposed that the connection string from ClickHouse and MySQL were fixed by this PR: https://github.com/openedx/tutor-contrib-aspects/pull/581. However, the asset generated with a random user/password were used instead. This PR makes sure that the SQL alchemy string is correct.

openedx-webhooks commented 4 months ago

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

bmtcril commented 4 months ago

What is the best way to test this? Is there any concern about bootstrapping a new instance with these changes?

Ian2012 commented 4 months ago

No, there isn't any concern on new instances. Already installed instances should be repaired.

You can test on a fresh local installation, and verify the connection string is using your current credentials instead of the ones on the CI of this repository

bmtcril commented 4 months ago

I've never run into the bug locally, though, is this only showing up in k8s?

openedx-webhooks commented 4 months ago

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.