openedx / tutor-contrib-aspects

The Open Analytics Reference System - Tutor plugin
Apache License 2.0
10 stars 14 forks source link

feat: allow to host dbt docs on cluster #892

Closed Ian2012 closed 2 weeks ago

Ian2012 commented 1 month ago

Description

This PR allows hosting dbt docs locally and on k8s. It also stores the manifest.json state file and superset exposures in clickhouse enabling us to remove the volume for the state. Closes: https://github.com/openedx/tutor-contrib-aspects/issues/915

Testing instructions

openedx-webhooks commented 1 month ago

Thanks for the pull request, @Ian2012!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @bmtcril. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

itsjeyd commented 1 month ago

Hey @bmtcril and @pomegranited, would you have time to give this PR a look?

Ian2012 commented 1 month ago

There are a couple of issues with this refactor:

bmtcril commented 3 weeks ago

Seems a little closer, I can init now, but k8s complains about the format of the deployment:

Error from server (BadRequest): error when creating "/Users/brianmesick/Dev/oars-tutor/env": Deployment in version "v1" cannot be handled as a Deployment: strict decoding error: unknown field "spec.template.metadata.containers", unknown field "spec.template.metadata.volumes"
Error: Command failed with status 1: kubectl apply --kustomize /Users/brianmesick/Dev/oars-tutor/env --selector app.kubernetes.io/component notin (job,volume,namespace)
openedx-webhooks commented 2 weeks ago

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.