Closed Ian2012 closed 2 weeks ago
Thanks for the pull request, @Ian2012!
Please work through the following steps to get your changes ready for engineering review:
If you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
This PR must be merged before / after / at the same time as ...
This PR is waiting for OEP-1234 to be accepted.
This PR must be merged by XX date because ...
This is for a course on edx.org.
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
This repository is currently maintained by @bmtcril
. Tag them in a comment and let them know that your changes are ready for review.
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Hey @bmtcril and @pomegranited, would you have time to give this PR a look?
There are a couple of issues with this refactor:
Seems a little closer, I can init now, but k8s complains about the format of the deployment:
Error from server (BadRequest): error when creating "/Users/brianmesick/Dev/oars-tutor/env": Deployment in version "v1" cannot be handled as a Deployment: strict decoding error: unknown field "spec.template.metadata.containers", unknown field "spec.template.metadata.volumes"
Error: Command failed with status 1: kubectl apply --kustomize /Users/brianmesick/Dev/oars-tutor/env --selector app.kubernetes.io/component notin (job,volume,namespace)
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This PR allows hosting dbt docs locally and on k8s. It also stores the
manifest.json
state file and superset exposures in clickhouse enabling us to remove the volume for the state. Closes: https://github.com/openedx/tutor-contrib-aspects/issues/915Testing instructions
RUN_ASPECTS_DOCS
in yourconfig.yml
.tutor dev do alembic -c "upgrade head"
tutor images build aspects