openedx / wg-build-test-release

Open edX Build / Test / Release Working Group
25 stars 15 forks source link

[TC_AUTHOR_36 > Enable course highlight emails ] Emails are not coming after enabling it #220

Closed fayyazahmed66 closed 1 year ago

fayyazahmed66 commented 1 year ago

Steps to reproduce:

  1. Go to the studio with valid admin credentials https://studio.olive.demo.overhang.io/course/course-v1:edly+edly0001+2022
  2. enable course highlight emails
  3. add highlights in the course section
  4. check if any email received to the learner

Expected result: As per flow, the learner must receive highlights emails after enabling the feature

Actual result: Emails are Not coming.

fayyazahmed66 commented 1 year ago

label: olive testing

mariajgrimaldi commented 1 year ago

Emails were being sent to the spam folder before, can you test again to see if this is working? Also, the docs say the emails are sent depending on the section due date, was this considered during the setup?

fayyazahmed66 commented 1 year ago

@mariajgrimaldi let me test it again by following your instructions and document. I will update you here.

DeanJayMathew commented 1 year ago

label: release blocker

mariajgrimaldi commented 1 year ago

@fayyazahmed66: let me know if you need help with this :)

mariajgrimaldi commented 1 year ago

This is a setup issue. First, the official documentation is out of date -edx docs-. Second, it's complex to setup. After hitting my head against a wall for quite some time, I found this doc that Jill at Opencraft attached to a post. They mentioned we need system admins' permissions for this to work, given that we need to run a command so the emails are sent. This raises an interesting question, what should we do with tests that need system admins' intervention? That's not the only issue, the setup must be proper for the course highlights to work with the command.

arbrandes commented 1 year ago

@mariajgrimaldi, so, it looks like we'll need @regisb's help to try and enable this in the demo server, right?

mariajgrimaldi commented 1 year ago

@arbrandes: right! Regarding the release blocker label, I'd say this is not a blocker since it didn't fail. Instead, it's missing the proper setup. Besides, this wasn't tested in Nutmeg either 🤔 What do you folks say?

regisb commented 1 year ago

@arbrandes Surely you meant to say that someone should write a plugin to enable course highlights, right? :stuck_out_tongue: In all seriousness, this is a feature that requires too much work to set up in core or the demo server. It's not like we need to enable a waffle flag or two. It's a shame because it looks like a great feature, but the required setup is just too complicated.

For instance:

  1. Why does it default to sending emails with sailthru and not the common Django mailer configuration?
  2. Why use cron jobs when we could use celery beat?
  3. Why do we need a site configuration, waffle switch AND waffle flag to enable this feature?
arbrandes commented 1 year ago

Makes sense, @regisb. :) Demoted to "enhancement".

Also letting you off the hook, @mariajgrimaldi. ;)

angonz commented 1 year ago

Hi all! We have created this tutor plugin that enables highlights and nudge emails. Hope it helps! Currently it only supports K8s. Maybe someone can volunteer and enhance it for local.

arbrandes commented 1 year ago

Closing this, as it is to be a plugin and not part of Tutor core.