search

openedx / wg-build-test-release

Open edX Build / Test / Release Working Group
25 stars 15 forks source link

Backport Mongo 4.0 support to Koa #24

Closed arbrandes closed 3 years ago

arbrandes commented 3 years ago

Mongo 3.6 is EOL on April 30th.

BbrSofiane commented 3 years ago

@blarghmatey I've added you to the repo, once you accept or comment on this issue I can assign it to you.

blarghmatey commented 3 years ago

You beat me to it, I was just adding a comment saying that I didn't have permissions to assign myself :)

blarghmatey commented 3 years ago

If anyone has pointers to specific code changes that need to be backported that would help, otherwise I'll do some code spelunking and test things out in our QA environment.

BbrSofiane commented 3 years ago

Pinging @cmltaWt0 in case he has any pointers

cmltaWt0 commented 3 years ago

Thanks @BbrSofiane

I've done some quick finding and it appears that backported code is already on koa.master (commit) and I hope we can find related commits.

@blarghmatey I'm going to search for the pymongo/mongo related updates in master branch and post here anything I'll find.

pomegranited commented 3 years ago

Brilliant, thank you for finding that commit @cmltaWt0 ! OpenCraft are testing the koa.1 release against a new Mongo 4.0 cluster (FAL-859), so we'll ensure the results are posted here. CC @arbrandes

BbrSofiane commented 3 years ago

@blarghmatey do you have any updates on this issue?

pomegranited commented 3 years ago

@BbrSofiane @blarghmatey CC @arbrandes We ran some testing with MongoDB 4.0 and open-release/koa.2a, and didn't find any issues with using the forum or modifying courseware.

So I think we can call this issue done!

BbrSofiane commented 3 years ago

@pomegranited sounds good. @blarghmatey Do we need to make mongo 4.0 the default in the configuration repo?

nedbat commented 3 years ago

Don't we have to change what version of Mongo is installed when you run the native installation?

pomegranited commented 3 years ago

@nedbat Ach yep we do.. @BbrSofiane @blarghmatey CC @arbrandes If someone can create a PR against the edx:configuration repo, I can review and merge as core committer.

arbrandes commented 3 years ago

For the time being, we're not porting Mongo 4.0 to Koa. We'll instead focus on installing it by default on Lilac. (See #47).