openedx / wg-build-test-release

Open edX Build / Test / Release Working Group
24 stars 15 forks source link

[Test failure] TC_LEARNER_44: Can't change site to some languages #347

Open Colin-Fredericks opened 4 months ago

Colin-Fredericks commented 4 months ago

Release

Redwood

Expected behavior

Changing the language for the site should make text appear in other languages.

Actual behavior

For some languages it works; for others it doesn't.

Steps to reproduce

  1. Open up account settings, like https://apps.redwood.demo.edly.io/account/#site-preferences
  2. Click or scroll to "Site Preferences".
  3. Click "Edit" next to "Site language".
  4. Pick a language. I chose French.
  5. Click "Save".
  6. Reload the page.
  7. Notice that the page is still in English and the setting has swapped back to English. (Not sure what happens if your site-wide default is set to something else.)

In a really weird twist, some languages work and some do not!

So a lot of them work, but not all of them. It seems my initial choice of French was sort of lucky here - I might not have realized this was broken otherwise.

Additional information

Fun fact: Pasting Hebrew or Arabic into the editor in GitHub gives you some really weird behavior, which I suppose I should have expected.

felipemontoya commented 4 months ago

I just tested this with "Español (Latinoamerica) and it failed likely due to a CORS issue.

image

GlugovGrGlib commented 4 months ago

@mariajgrimaldi @cmltaWt0 I'm facing exactly the same issue with CORS as @felipemontoya posted above.

I believe the issue is that endpoint /i18n/setlang/ returns Redirect to / instead of JSON response, and when Learner-dashboard MFE is enabled it's being blocked by CORS policy.

Please see screenshots:

Chromium:

image

Firefox:

Screenshot 2024-05-29 at 14 12 03

Did this case pass for Quince, since learner-dashboard MFE was included in the community release?

mariajgrimaldi commented 4 months ago

@GlugovGrGlib: we don't have a failing report for quince, so I'll be testing in a quince installation to be sure.

mariajgrimaldi commented 4 months ago

@GlugovGrGlib: I tested here https://apps.sandbox.openedx.edly.io/account/, and I can confirm it is also happening in quince. I can change the language, but the changes are reflected after reloading. Also, I get the CORS error as well. I haven't tested all the languages yet.

image

mariajgrimaldi commented 1 month ago

I'll be opening an issue in the tutor-mfe repo so we can address it there. Thank you all!