search

openedx / wg-build-test-release

Open edX Build / Test / Release Working Group
25 stars 15 forks source link

Lilac to install with Mongo 4.0 #47

Closed BbrSofiane closed 3 years ago

BbrSofiane commented 3 years ago

Lilac to install with Mongo 4.0

BbrSofiane commented 3 years ago

@arbrandes At the last meeting, did you mention that someone at Open Craft was looking at this?

BbrSofiane commented 3 years ago

@arbrandes did you manage to find more information on this?

regisb commented 3 years ago

Looks like we need to upgrade the pymongo requirement of the configuration repo: https://github.com/openedx/build-test-release-wg/issues/63#issuecomment-836180590

arbrandes commented 3 years ago

@BbrSofiane, I had hoped OpenCraft would've had to deal with this by now, but those internal tasks have been delayed. Which is to say, I'm still trying to find an assignee.

@regisb, that looks like it's part of the problem, yes. Thanks!

pomegranited commented 3 years ago

@arbrandes @BbrSofiane I've created a task for Opencraft to do this next sprint (May 18 - June 1), so we'll post here when there's a PR ready.

@regisb

Looks like we need to upgrade the pymongo requirement of the configuration repo: https://github.com/openedx/build-test-release-wg/issues/63#issuecomment-836180590

We'll update pymongo as part of this too, thanks for noting this.

Our ticket description covers the following, does this look complete?

Full description

MongoDB 3.6 reached end of life on April 30, 2021.

However, the openedx_native.yml playbook still deploys mongodb3.6, as does the docker playbook.

You will likely also need to update pymongo to <3.11 as used in edx-platform, cf https://github.com/openedx/build-test-release-wg/issues/63.

Update these to use the mongo_4_0 role, and submit the fix upstream to master.

No need to submit this change to our local release branches -- we always use externally-deployed mongodb databases, and so these changes don't affect us.

Fixes https://github.com/openedx/build-test-release-wg/issues/47.

Completion criteria

regisb commented 3 years ago

According to my own tests, Lilac runs fine on Mongodb 4.0. I upgraded a Mongodb 3.6 database (from Koa) to 4.0 and did not encounter any issue. The procedure should be the same as for the 3.4 -> 3.6 upgrade: https://docs.mongodb.com/manual/release-notes/4.0-upgrade-standalone/

  1. Replace Mongodb 3.6 by Mongodb 4.0
  2. Run db.adminCommand({ setFeatureCompatibilityVersion: "4.0" })

Note that my testing was quite superficial. I'll come back and edit this issue if I encounter any problem down the road.

mtyaka commented 3 years ago

I opened https://github.com/edx/configuration/pull/6416 to update mongo in the openedx_native.yml playbook to 4.0 and https://github.com/edx/configuration/pull/6420 to cherry-pick the change to the lilac branch.

Does anyone know what the status of the docker playbook is? It's still using 3.2. I did not upgrade it since it might make more sense to remove it rather than upgrade if it's not being used anywhere.

mtyaka commented 3 years ago

The PRs (1, 2) that upgrade mongo to 4.0 have been merged to edx/configuration master and open-release/lilac.master. Can we close this issues or is there anything else to do @BbrSofiane @arbrandes?

BbrSofiane commented 3 years ago

@mtyaka Looks good to me, thanks for taking care of this!

arbrandes commented 3 years ago

Thanks @mtyaka! 👍🏼