openedx / wg-build-test-release

Open edX Build / Test / Release Working Group
25 stars 15 forks source link

The native installation should pin MFE versions #90

Closed arbrandes closed 3 years ago

arbrandes commented 3 years ago

Description

Recently, a commit that likely introduced a backward-incompatible change (if not a bonafide bug!) to the Gradebook MFE and Lilac.master. Even if the Gradebook is not officially supported for Lilac by the BTR group, we need a way to avoid such upstream changes from breaking the other ones.

A suggested solution is to add the following to the pre-existing MFE vars on openedx_native.yml:

MFE_DEPLOY_VERSION: {{ OPENEDX_RELEASE }}

Acceptance criteria

Estimated effort

2 hours of a developer experienced with the native installation

Bounties

N/A

BbrSofiane commented 3 years ago

@arbrandes What were the steps to reproduce this issue?

I've run a native installation and all the MFEs are checked out with the correct branch (open-release/lilac.master).

Looking at edx/configuration/install/native.sh, MFE_DEPLOY_VERSION is set by the install script.

arbrandes commented 3 years ago

@BbrSofiane, excellent catch. This issue was reported to me by the Opencraft team when deploying via Ocim, and I neglected to check native.sh. I guess we can close this, then. :)