search

openedx / wg-frontend

Open edX Frontend Working Group
4 stars 0 forks source link

Proposal: ignore ESLint for module.config.js file in @edx/frontend-build #115

Closed adamstankiewicz closed 1 year ago

adamstankiewicz commented 2 years ago

As a consumer of @edx/frontend-build, I was getting ESLint warnings in my module.config.js file. However, this file is not code that gets shipped as part of any JS bundles to the end user and doesn't necessarily matter from a linting perspective. To eliminate erroneous linting errors that could arise in module.config.js, it might be worth adding module.config.js to ESLint's ignorePatterns so linting does not occur on this file.

arbrandes commented 1 year ago

@BilalQamar95, are you working on this? Should we put this in the backlog for somebody else to pick up?

BilalQamar95 commented 1 year ago

@arbrandes PR for this issue has been merged, this can be closed as completed