Migrate off `babel-plugin-react-intl` in favor of `babel-plugin-formatjs`

openedx / wg-frontend

Open edX Frontend Working Group

4 stars 0 forks source link

Closed adamstankiewicz closed 5 months ago

adamstankiewicz commented 2 years ago

The babel-plugin-react-intl package that @edx/frontend-build uses in its Babel configs is deprecated in favor of babel-plugin-formatjs.

Modify @edx/frontend-build to no longer rely on babel-plugin-react-intl in favor of babel-plugin-formatjs.

arbrandes commented 1 year ago

@BilalQamar95, just checking: are you working on this? Or should we put it in the backlog for somebody else to pick up?

BilalQamar95 commented 1 year ago

@arbrandes There is a PR for it waiting for review

arbrandes commented 1 year ago

PR was reviewed, but there are some remaining concerns. In other words, this is still in progress.

BilalQamar95 commented 1 year ago

The PR for it(frontend-build#258) was a breaking change causing translation failures for consumers, reference https://github.com/edx/frontend-component-header-edx/issues/338. Reopening this, since the PR was reverted & migration towards babel-plugin-formatjs in still in progress while we further look into it.

arbrandes commented 5 months ago

Looks like we're done here. Thanks for all this work!