openedx / wg-frontend

Open edX Frontend Working Group
4 stars 0 forks source link

Support `codecov-action@v4` breaking changes #177

Open brian-smith-tcril opened 3 months ago

brian-smith-tcril commented 3 months ago

From slack:

Hi team, we noticed that Codecov has stopped working in frontend-app-authn recently. It seems like it can't find the token. Does anyone have any idea on how to resolve this?

This happened because https://github.com/openedx/frontend-app-authn/pull/1172 was merged which bumped the codecov action from v3 to v4 without accounting for the breaking changes

Tokenless uploading is unsupported

We use the codecov workflow in quite a few places throughout the org https://github.com/search?q=org%3Aopenedx+uses%3A+codecov%2Fcodecov-action&type=code and I expect dependabot PRs to start making it into a bunch of those repos.

If we want to move to the v4 version of the action we should ensure we make the required changes to support it

brian-smith-tcril commented 3 months ago

@syedsajjadkazmii it seems in the short term we should just move back to the v3 version of the action because

jristau1984 commented 3 months ago

Should this still be broken for repos?

brian-smith-tcril commented 3 months ago

It seems the v3 action has started having more intermittent failures. We've also found that codecov requires a repository secret, and cannot use an org secret. If the v3 action is causing issues on a repo the best course of action is to create a request ticket (https://github.com/openedx/axim-engineering/issues/new?assignees=&labels=github-request&projects=&template=04-github-request---repo-settings.yml&title=%5BGH+Request%5D+%3CADD+A+REQUEST+TITLE+HERE%3E) - then someone from Axim can add the repo secret and make a PR updating the action to v4.