search

openedx / wg-frontend

Open edX Frontend Working Group
4 stars 1 forks source link

Node 16 upgrade for frontend-platform #28

Closed binodpant closed 1 year ago

binodpant commented 2 years ago

This task is a subtask/offshoot of https://github.com/openedx/frontend-wg/issues/2 where it was discussed that it will be one concrete deliverable if we can upgrade frontend-platform on its own to use a new node/npm pair, without (ideally) affecting any existing workflows. If that is not feasible, meaning it affects devs' workflows, then one should pause and discuss with frontend-wg.

binodpant commented 2 years ago

PR created https://github.com/edx/frontend-platform/pull/256

binodpant commented 2 years ago

https://app.travis-ci.com/github/edx/frontend-platform/builds/241823086

binodpant commented 2 years ago

PR updated to use GH actions, and add readme doc.

binodpant commented 2 years ago

Updated PR is https://github.com/edx/frontend-platform/pull/259

binodpant commented 2 years ago

There is an issue when starting example app, it may need more investigation, will update in PR

binodpant commented 2 years ago

@davidjoy is going to fix an issue in frontend-build that blocks this, basically webpack 4 is somehow being brought it via peer deps hence it causes an error during startup of the example app

~/work/frontend-platform (master ✘)✹ ᐅ npm start

> @edx/frontend-platform@1.0.0-semantically-released start
> fedx-scripts webpack-dev-server --progress

Running with resolved config:
/Users/binodpant/work/frontend-platform/webpack.dev.config.js

No local module configuration file found. This is fine.
[webpack-cli] Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.resolve has an unknown property 'fallback'. These properties are valid:
   object { alias?, aliasFields?, cachePredicate?, cacheWithContext?, concord?, descriptionFiles?, enforceExtension?, enforceModuleExtension?, extensions?, fileSystem?, ignoreRootsErrors?, mainFields?, mainFiles?, moduleExtensions?, modules?, plugins?, preferAbsolute?, resolver?, roots?, symlinks?, unsafeCache?, useSyncFileSystemCalls? }
   -> Options for the resolver

once that resolves, I will update what I can do on this upgrade for this repo

binodpant commented 2 years ago

Resolved by David's fix to frontend-build https://github.com/edx/frontend-platform/pull/265

binodpant commented 2 years ago

this is still a valid task but will be executed after MFEs have been ported to node 16 so that there is no breakage in MFE workflows