search

openedx / wg-translations

Repository for Translation Working Group docs and issues.
0 stars 0 forks source link

Numerous String IDs in the various .js files in the repository are not properly harvested, collected and sent to Transifex for translations #24

Open ehuthmacher opened 9 months ago

ehuthmacher commented 9 months ago

Relevant summary: https://discuss.openedx.org/t/translations-issues-with-the-frontend-app-learner-dashboard/12287

Issue: https://github.com/openedx/frontend-app-learner-dashboard/issues/287

ehuthmacher commented 9 months ago

Impacted resources: frontend-app-communications and frontend-app-learner-dashboard resources

ehuthmacher commented 9 months ago

TX team can run tests to ensure that all strings defined in a particular resource are added to the strings that are sent to Transifex for translations - need source files for testing.

We can start running tests for frontend-app-communications and frontend-app-learner-dashboard and then test all MFE's for quality assurance.

ehuthmacher commented 9 months ago

This will be an ongoing issue. Each repo maintainer will have to fix errors, as they are flagged. @brian-smith-tcril do you agree with this approach?

brian-smith-tcril commented 9 months ago

@OmarIthawi's solution proposed in the comment here https://github.com/openedx/frontend-app-learner-dashboard/issues/287#issuecomment-1937016519 will likely resolve a large proportion of the missing string issues.

I also agree we should make issues on repos where missing strings are found. It would be ideal to link to documentation so we don't need to repeat ourselves when explaining the problem and suggesting solutions. I think that documentation should likely live here https://docs.openedx.org/en/latest/translators/concepts/translation-process.html.

That being said, I don't think we can rely on repo maintainers to fix these issues. We should expect repo maintainers to keep translations in mind when reviewing PRs (to prevent new strings that aren't being picked up from being added), and to review and merge PRs that fix the existing issues in a timely manner, but I expect we will (realistically I will) need to dedicate some engineering effort to address the existing issues.