Open ehuthmacher opened 1 year ago
@ghassanmas @sambapete please add several examples
A few examples:
I would even say 6 times if you also include the single use of 'upgrade now' without capitalization.
One thing to consider is that while the default messages may be identical, it's possible they were coded as separate strings instead of using a shared variable intentionally to provide flexibility. With that in mind, it makes sense to have maintainers on each repo decide on a case by case basis if the duplicates need to stay or not.
I think a good path forward for this is to make an issue on each repo that has duplicate strings, and link back to this issue.
That way, this issue can provide the "why," while the issues on each repo can discuss the "what" and "how."
@brian-smith-tcril How about the future approach for prevention? Can we make it a rule that maintainers check if duplicate strings exist?
@brian-smith-tcril How about the future approach for prevention? Can we make it a rule that maintainers check if duplicate strings exist?
We discussed the possibility of having an eslint
rule to check for messages with duplicate defaultMessage
.
I activated translation memory in the openedx-translation project, which should avoid these issues moving forward.
I activated translation memory in the openedx-translation project, which should avoid these issues moving forward.
@ehuthmacher Thanks! I'm wondering if you've enabled the memmory in the openedx-translations
project in the same Translation Memory group with the old edx-platform
and xblocks
projects?
If not, please check the translation memory sharing document from Transifex: https://help.transifex.com/en/articles/6225301-sharing-translation-memory
Translation files are requiring for the same terms to be translated multiple times. The original translation should auto-populate for increased efficiency.