Closed shadinaif closed 1 year ago
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Please review @OmarIthawi, @brian-smith-tcril
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
feat: standardize make extract_translations
This PR prepares the repository to comply with openedx-translations by doing the following:
Move all local translations to
conf/locale
and converttranslations
into a symbolic link toconf/locale
. The reason behind that is to comply with openedx-translations mechanism that requires translation files to be inconf/locale
directory. This fix will avoid the need to modifyfind
commands hereFor the same reason above,
locale
now linked toconf/locale
instead oftranslations
Make the translation command
make extract_translations
build a file nameddjango.po
instead oftext.po
. And create a symbolic link fromtext.po
todjango.po
. This is because openedx-translations requiresdjango.po
as the name of the file. And it must be a valid file (not a link) because it usesgit add
here[x] Tested on devstack palm to ensure that everything renders fine
[x] Tested on devstack palm to ensure that local translation still works
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks