openedx / xblock-image-explorer

GNU Affero General Public License v3.0
9 stars 39 forks source link

feat!: remove Transifex calls for FC-0012 - OEP-58 #112

Closed shadinaif closed 7 months ago

shadinaif commented 9 months ago

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

## Keep this pull request as a draft to prevent an accidental merge. ##

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

openedx-webhooks commented 9 months ago

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

shadinaif commented 9 months ago

for your review @OmarIthawi

shadinaif commented 9 months ago

Please review again @OmarIthawi , we have a separate PR for the lang files remove https://github.com/openedx/xblock-image-explorer/pull/114

OmarIthawi commented 8 months ago

@shadinaif please set as ready for merge by removing draft status.

openedx-webhooks commented 7 months ago

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.