search

openedx / xblock-image-explorer

GNU Affero General Public License v3.0
9 stars 39 forks source link

Fix for hot-spot sprite image not visible on production like environment #26

Closed ziafazal closed 7 years ago

ziafazal commented 7 years ago

This PR address an issue where hot-spot sprite image not visible when assets are compiled on production environment. Sprite url was generated with this statement

sprite_url = self.runtime.local_resource_url(self, 'public/images/hotspot-sprite.png')

which give and invalid url relevant to studio environment some like this (/c4x/MMBA/IE230/asset/xblock_resources_image_explorer.image_explorer_public_images_hotspot-sprite.8e637638fd95.8e637638fd95.png)

More detail of the issue can be found here

@bradenmacdonald can some one from you team review this?

bradenmacdonald commented 7 years ago

@ziafazal Sure thing, we'll assign a reviewer on Monday.

ziafazal commented 7 years ago

@e-kolpakov Can you review this?

itsjeyd commented 7 years ago

@ziafazal I'll be reviewing this PR for our team.