search

openedx / xblock-image-explorer

GNU Affero General Public License v3.0
9 stars 39 forks source link

MCKIN-8752: Make max_score a method instead of a property. #53

Closed jcdyer closed 5 years ago

jcdyer commented 5 years ago

Description goes here. e.g. This PR contains the LibraryContent XBlock, which allows to display library content in a course.

JIRA tickets: Implements SOL-5, SOL-6.

Discussions: Architecture discussed extensively on the wiki and in meetings, then the revised proposal was presented to the Arch Council on Oct. 21 and given thumbs up.

Dependencies: None

Screenshots:

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

  1. If you don't have a course with an image-explorer xblock, go into studio, under settings / Advanced settings / Advanced Module List for a course add "image-explorer", to the top of the list. Then in the course, add an image-explorer block.

  2. Visit a course with an image-explorer xblock. Verify that returns a 500 on a JsonDecodeError (or was it JsonEncodeError?)

  3. pip Install this branch

  4. Verify it doesn't fail. Author notes and concerns:

  5. We are aware that there is a glitch affecting the UI for this feature in the following way: ... Currently looking for ways to fix it.

  6. We tried to optimize for accessibility, but there are still some open questions: ...

Reviewers

Settings

EDXAPP_FEATURES:
  ENABLE_COMBINED_LOGIN_REGISTRATION: true
jcdyer commented 5 years ago

Just rebased to add the version bump.