search

openedx / xblock-image-explorer

GNU Affero General Public License v3.0
9 stars 39 forks source link

BB-1025 Add visited hotspots styling #56

Closed xirdneh closed 5 years ago

xirdneh commented 5 years ago

This PR adds a visited attribute to visited hotspots and adds a class in the HTML that will simulate a "hover" state. The result is visually rendering visited hotspots as if they were in the "hover" state.

JIRA tickets:

Discussions:

Dependencies: None

Screenshots: Screen Shot 2019-03-18 at 12 02 45 PM In the screenshot the leftmost and uppermost hot-spots has been visited.

Sandbox URL:

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

  1. Checkout this branch
  2. Visit a few image hotspots.

Author notes and concerns:

Reviewers

xitij2000 commented 5 years ago

@xirdneh This is working perfectly for me, but the tests are not passing. Could you have a look?

xirdneh commented 5 years ago

@xitij2000 I've update the version in setup.py is that all that's necessary for the version bump?

xitij2000 commented 5 years ago

@xirdneh Yes. I will create a github tag after merging.