openedx / xblock-image-explorer

GNU Affero General Public License v3.0
9 stars 39 forks source link

Tracking logs and a workbench scenario #6

Closed dragonfi closed 10 years ago

ericouyang commented 10 years ago

Revised event names:

xblock.image-explorer.loaded xblock.image-explorer.hotspot.opened xblock.image-explorer.hotspot.closed

aboudreault commented 10 years ago

LGTM, when ericouyang comments are addressed.

antoviaque commented 10 years ago

Adding another good remark from @ericouyang which applies to all the XBlocks to which we're adding events:

"_One thing that I do think is worth implementing is for the original show events (now called loaded) to be triggered in javascript once the xblock has finished loading on the client side, rather than on the server-side in student_view_"

dragonfi commented 10 years ago

@antoviaque Yep, loaded does clarify the meaning, I can do that.

dragonfi commented 10 years ago

@ericouyang @antoviaque PR updated with suggested changes.

ericouyang commented 10 years ago

@dragonfi LGTM!