Closed dragonfi closed 10 years ago
LGTM, when ericouyang comments are addressed.
Adding another good remark from @ericouyang which applies to all the XBlocks to which we're adding events:
"_One thing that I do think is worth implementing is for the original show
events (now called loaded
) to be triggered in javascript once the xblock has finished loading on the client side, rather than on the server-side in student_view
_"
@antoviaque Yep, loaded
does clarify the meaning, I can do that.
@ericouyang @antoviaque PR updated with suggested changes.
@dragonfi LGTM!
Revised event names:
xblock.image-explorer.loaded xblock.image-explorer.hotspot.opened xblock.image-explorer.hotspot.closed