add Icons and remove pseudo element from the css to Improve the Accessibility.

hussnain2 commented 4 years ago

…sibility.

openedx-webhooks commented 4 years ago

Thanks for the pull request, @hussnain2! I've created OSPR-3941 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information.

hussnain2 commented 4 years ago

@msaqib52 @murad-hubib Please review.

nasirhjafri commented 4 years ago

@hussnain2 Tests won't run on a PR from forked repo.

hussnain2 commented 4 years ago

SO I need to Get Access for Open_edx to get these changes done with tests @nasirhjafri ?

CC: @murad-hubib

natabene commented 4 years ago

This Xblock only exists in edx-solutions, it doesn't exist in https://github.com/edx. @nasirhjafri You will not need edX review to merge, correct?

hussnain2 commented 4 years ago

Hi @natabene Please ignore this PR, as we have been created another PR by getting Fork from open-Edx

CC: @murad-hubib @nasirhjafri

openedx / xblock-image-explorer

add Icons and remove pseudo element from the css to Improve the Accessibility. #66