search

openedx / xblock-image-explorer

GNU Affero General Public License v3.0
9 stars 39 forks source link

SE-3013 Added parsel library to the setup.py required dependencies #84

Closed s0b0lev closed 4 years ago

s0b0lev commented 4 years ago

Description

Added parsel requirements to package dependencies. Without this package, xblock-image-explorer is not installed properly.

Testing instructions:

  1. Run instance and provide link to xblock-image-explorer
  2. Get working instance with properly configures xblock-image-explorer

Author notes and concerns:

Would be cool to setup xblock-image-explorer python package to include all required dependencies at setup.py (or even publish to pypi)

s0b0lev commented 4 years ago

Hi @ziafazal, could you make a review of this PR?

toxinu commented 4 years ago

cc @shafqatfarhan @musmanmalik @msaqib52 Would you have to review this pull request please?

nizarmah commented 4 years ago

@s0b0lev could you please close this PR? The changes of this PR were cherry picked, squashed, and included in #85

Here's the added parsel package, updated to v1.6 instead of v1.2

s0b0lev commented 4 years ago

@nizarmah thanks for the update :ok_hand: