search

openedx / xblock-image-explorer

GNU Affero General Public License v3.0
9 stars 39 forks source link

build: replace Circle CI with GitHub CI #98

Closed UsamaSadiq closed 2 years ago

UsamaSadiq commented 2 years ago

Issue: BOM-3116

Description

kdmccormick commented 2 years ago

Closing and reopening to see if it drops the circleci check.

kdmccormick commented 2 years ago

Hey @UsamaSadiq , I told CircleCI to "Stop Building" this repo, and disabled GH status reporting from Advanced Settings.

image

I then went into Branch Protection Rules for this repository:

image

Normally this is where I'd "Edit" the master branch protection rule, un-checking circleci as a required check. Since there were no branch protection rules though at all, though, I don't think anything needs to be done here.

I think you are good to merge this PR with the failing circleci check, since it's an optional check. If you open a new PR later, circleci shouldn't appear, since you've removed the config file and we've disabled building on the CircleCI side.

kdmccormick commented 2 years ago

@UsamaSadiq can you open a trivial PR after this one merges just to ensure that the CircleCI check is gone?

UsamaSadiq commented 2 years ago

Created the PR https://github.com/openedx/xblock-image-explorer/pull/99 to test that circle ci check has been removed.