openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
28 stars 83 forks source link

Custom Parameters not working in LTI 1.3 DL Launch #232

Open AqibYounasAtTkxel opened 2 years ago

AqibYounasAtTkxel commented 2 years ago

Hi there, I am trying to send the user email to my tool in LTI1.3 launch but it looks like it haven't been done on your side & custom parameters option do not work. kindly resolve this as this is a very basic requirement for tools

Alain1405 commented 2 years ago

I confirm both custom parameters and the admin/lti_consumer/courseallowpiisharinginltiflag/ don't work with LTI1.3.

Alain1405 commented 2 years ago

Let me add some more details for future reference. Both custom parameters configuration and configs for sending username and email show on the 1.3 consumer block configuration but are only supported on version 1.1. In order to enable sending user Personal Identifiable Information on 1.1 you need to enable the admin/lti_consumer/courseallowpiisharinginltiflag/ flag.

Here are the configs I refer to:

Screenshot 2022-02-09 at 20 52 36

If you want to get user details on 1.3, you can still enable NRPS on the consumer block @AqibYounasAtTkxel and then send a request to NRPS to get info of all students, and then match that info with the ID of the student launching the tool side.

That said, it would be pretty trivial to allow sending PII with 1.3 @giovannicimolin . Let us know if you are interested in the contribution https://github.com/OlhaShyliaieva/xblock-lti-consumer/compare/master...OlhaShyliaieva:shyliaieva/add_user_info

UPDATE: Actually you need to enable admin/lti_consumer/courseallowpiisharinginltiflag/ on 1.3 in order to send user personal details. If the flag is disabled, you will only receive user id, status and roles. If it's enabled you will also get name and email as well when configured in the LTI consumer.

FatemeKhodayari commented 10 months ago

Hi. I'm facing similar issue. I'm using LTI 1.3 with h5p.com and have enabled the course allow pii sharing flag at https://lms.mydomain.com/admin/lti_consumer/courseallowpiisharinginltiflag/. Both Request user's username and Request user's email are set to True on the block configuration.

image

I'm getting users emails on h5p but not their username. What's the issue? Another question is that how / where should I set the extra parameters so that other user info such as name (first name, last name) is sent to h5p?

besonn commented 1 month ago

@FatemeKhodayari @Alain1405 Hi ! The same error occurred to me, did you fixed it ?