openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
28 stars 81 forks source link

feat: adds setting to prevent nrps pii #315

Closed Zacharis278 closed 1 year ago

Zacharis278 commented 1 year ago

MST-1737

This is a temporary solution. We would like to enable PII in an LTI1.3 launch but turning that flag on would allow the tool to grab PII for the entire course roster via NRPS. We have not fully evaluated the privacy concerns if that is allowed. For the time being this platform setting can wholly disable PII over NRPS to avoid the issue.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.80% // Head: 97.70% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (da3e0f1) compared to base (b6d2066). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #315 +/- ## ========================================== - Coverage 97.80% 97.70% -0.10% ========================================== Files 72 75 +3 Lines 5913 6011 +98 ========================================== + Hits 5783 5873 +90 - Misses 130 138 +8 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.70% <100.00%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [lti\_consumer/\_\_init\_\_.py](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [lti\_consumer/plugin/compat.py](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL3BsdWdpbi9jb21wYXQucHk=) | `76.66% <100.00%> (+2.59%)` | :arrow_up: | | [lti\_consumer/plugin/views.py](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL3BsdWdpbi92aWV3cy5weQ==) | `95.35% <100.00%> (ø)` | | | [lti\_consumer/exceptions.py](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL2V4Y2VwdGlvbnMucHk=) | `100.00% <0.00%> (ø)` | | | [lti\_consumer/utils.py](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL3V0aWxzLnB5) | `91.20% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.