openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
28 stars 81 forks source link

feat: support separate different base urls for UI flow and API callbacks #319

Closed Zacharis278 closed 1 year ago

Zacharis278 commented 1 year ago

MST-1732

Allows independent configuration of the base URL used for LTI API requests and LTI browser flow. This primarily aids local development because we no longer have to tunnel the entire LMS in order to test against the IMS tools. You can use your normal browser steps to login to the LMS and access content without hacking up your settings which can break other parts of the platform.

Testing LTI launches in another service or IDA is particularly problematic right now because we need to tunnel multiple services (LMS + IDA).

This change would also support cases where a service may have a separate URL scheme for backend requests like the OAuth flow versus frontend redirects, which need to make use of specific browser cookies.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.68% // Head: 97.65% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (e5a4b37) compared to base (f3eca6b). Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head e5a4b37 differs from pull request most recent head e49ffad. Consider uploading reports for the commit e49ffad to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #319 +/- ## ========================================== - Coverage 97.68% 97.65% -0.04% ========================================== Files 75 75 Lines 6090 6096 +6 ========================================== + Hits 5949 5953 +4 - Misses 141 143 +2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.65% <66.66%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [lti\_consumer/models.py](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL21vZGVscy5weQ==) | `91.36% <ø> (ø)` | | | [lti\_consumer/utils.py](https://codecov.io/gh/openedx/xblock-lti-consumer/pull/319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL3V0aWxzLnB5) | `89.69% <66.66%> (-1.52%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Zacharis278 commented 1 year ago

@MichaelRoytman you have any concerns with this one?