openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
28 stars 84 forks source link

fix: ensure platform name is string #368

Closed alangsto closed 1 year ago

alangsto commented 1 year ago

Typecast PLATFORM_NAME to a string to ensure that it can be parsed correctly by Oauth code. This fix will unblock the release of this library in edx-platform, which is currently blocked by failing tests: https://github.com/openedx/edx-platform/pull/32166.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (47a1f40) 97.72% compared to head (27006f9) 97.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #368 +/- ## ======================================= Coverage 97.72% 97.72% ======================================= Files 77 77 Lines 6281 6281 ======================================= Hits 6138 6138 Misses 143 143 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.72% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [lti\_consumer/lti\_1p1/consumer.py](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL2x0aV8xcDEvY29uc3VtZXIucHk=) | `96.80% <ø> (ø)` | | | [lti\_consumer/\_\_init\_\_.py](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [lti\_consumer/lti\_1p3/consumer.py](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL2x0aV8xcDMvY29uc3VtZXIucHk=) | `97.27% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.