openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
28 stars 84 forks source link

fix: make extract_translations #371

Closed shadinaif closed 1 year ago

shadinaif commented 1 year ago

References

This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Check the links above for full information about the overall project.

Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:

Breaking Changes

One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes

For XBlocks:

openedx-webhooks commented 1 year ago

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (98ed45f) 97.75% compared to head (67d1c45) 97.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #371 +/- ## ======================================= Coverage 97.75% 97.75% ======================================= Files 77 77 Lines 6371 6371 ======================================= Hits 6228 6228 Misses 143 143 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `97.75% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

brian-smith-tcril commented 1 year ago

It seems this is following the same pattern as https://github.com/openedx/xblock-drag-and-drop-v2/pull/326

Once the requested changes on that one have been made this should be updated to match the approved pattern. I'm marking this as "blocked by other work" for now

shadinaif commented 1 year ago

Done @brian-smith-tcril

mphilbrick211 commented 1 year ago

Hi @shadinaif @brian-smith-tcril - is this ready for review?

brian-smith-tcril commented 1 year ago

@mphilbrick211 yes it is! According to the spreadsheet a review is required from @MichaelRoytman

openedx-webhooks commented 1 year ago

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.